Feature #2247
closed
registry_ini.c: Stop adding gettext marking around empty strings
Added by Marko Lindqvist about 1 month ago.
Updated 4 days ago.
Description
Split from #1893:
Do not place _() marking around empty string (""), even when gettext marking is requested. Do that with as clean an API as possible, though.
Files
- Blocks Bug #1893: ruledit and ruleup output has issues with _() added
- Target version set to 3.3.0-beta1
This patch can also work for S3_2.
- We shouldn't silently override what caller requests. Maybe the best solution is to "return !gt_marking;" in case we set marking to FALSE, i.e., to return error if gt_marking is not what was requested.
- Check against empty strings with pentry->string.value0 != '\0', strlen() is quite heavy operation for that (esp. if the string happens to be long).
- Status changed from New to In Progress
- Assignee set to Dean Brown
- File deleted (
2247.patch)
- Status changed from In Progress to In Review
- Assignee changed from Dean Brown to Marko Lindqvist
- Target version changed from 3.3.0-beta1 to 3.2.7
- Status changed from In Review to Closed
Also available in: Atom
PDF