Project

General

Profile

Actions
Copy link

Bug #2272

open

execute_orders() calling action_id_get_target_kind(order.action) multiple times for the same action

Added by Marko Lindqvist 23 days ago. Updated 11 days ago.

Status:
In Review
Priority:
Normal
Assignee:
Marko Lindqvist
Category:
Server
Target version:
3.2.7
Start date:
09/21/2026
Due date:
% Done:

0%

Estimated time:

Description

execute_orders() handling of ORDER_PERFORM_ACTION does multiple action_id_get_target_kind(order.action) calls for the same action being handled. This should be otherwise harmless, but clang analyzer does not know that each function call gives the same result, so gives some warnings that would make sense if those results were inconsistent.
Seen on main branch.

Files

Download all files
0089-execute_orders-Call-action_id_get_target_kind-just-o.patch (2.6 KB) 0089-execute_orders-Call-action_id_get_target_kind-just-o.patch main Marko Lindqvist, 10/04/2026 03:30 AM
0036-execute_orders-Call-action_id_get_target_kind-just-o.patch (2.58 KB) 0036-execute_orders-Call-action_id_get_target_kind-just-o.patch S3_3 Marko Lindqvist, 10/04/2026 03:30 AM
0031-execute_orders-Call-action_id_get_target_kind-just-o.patch (2.58 KB) 0031-execute_orders-Call-action_id_get_target_kind-just-o.patch S3_2 Marko Lindqvist, 10/04/2026 03:30 AM
Actions
Copy link

Also available in: Atom PDF