Feature #2334: city_add_unit(), handle spec_type either nullptr or not - Freeciv - Freeciv Ticket System

Actions

Copy link

Feature #2334

closed

city_add_unit(), handle spec_type either nullptr or not

Added by Dean Brown 30 days ago. Updated 11 days ago.

Status:

Closed

Priority:

Normal

Assignee:

Marko Lindqvist

Category:

Server

Target version:

3.4.0

Start date:

10/05/2026

Due date:

% Done:

Estimated time:

Description

Follow on to #1618 and #2187, dealing with super specialists and possibility of unit_type's spec_type being nullptr.

Files

2334.patch (841 Bytes) 2334.patch

Dean Brown, 10/17/2026 05:01 AM

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Dean Brown 30 days ago

File 2334.patch added

Main only.

Actions

Copy link

Updated by Marko Lindqvist 30 days ago

Blocked by Feature #2187: Main: load_ruleset_units(): allow spec_type to be NULL if no specialist entry added

Actions

Copy link

Updated by Marko Lindqvist 19 days ago

Does this patch (as it's currently implement) change anything? Isn't the auto_arrange_workers() in the end converting the specialists to field workers even if they are, for less than a millisecond, specialists of other type than DEFAULT_SPECIALIST?
Even if it doesn't, calling auto_arrange_workers() breaks things when unit spec_type is DEFAULT_SPECIALIST.

I think this ticket should basically replace "if (is_super_specialist()) {" with "if (act_utype->spec_type != nullptr) {"

Actions

Copy link