Bug #2361: Qt: city_production_model::setData() always early exits - Freeciv - Freeciv Ticket System

Actions

Bug #2361

open

Added by Marko Lindqvist 3 days ago. Updated 3 days ago.

Status:

In Review

Priority:

Normal

Assignee:

Category:

Qt-client

Target version:

Start date:

10/11/2026

Due date:

% Done:

Estimated time:

Description

The city_production_model::setData() condition

if (!index.isValid() || role != Qt::DisplayRole || role != Qt::ToolTipRole)

is always true, since role cannot be simultaneously both Qt::DisplayRole and Qt::ToolTipRole

Files

Marko Lindqvist, 10/11/2026 07:38 AM

Actions

File 0091-Qt-Drop-city_production_model-setData.patch 0091-Qt-Drop-city_production_model-setData.patch added
Status changed from New to In Review
Assignee set to Marko Lindqvist
Target version set to 3.4.0

As far as I can see, whole function was completely pointless. Drop it, but only from development branch.

Actions

Also available in: Atom PDF