Project

General

Profile

Actions
Copy link

Bug #239

closed

mapgenerator4() codeQL warning about bad oddness check

Added by Marko Lindqvist 10 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Marko Lindqvist
Category:
Server
Target version:
3.1.0
Start date:
02/08/2024
Due date:
% Done:

0%

Estimated time:

Description

mapgenerator4() has a oddness check of form "x % 1 == 1", which would not work for negative numbers. The number is never negative in this code, but let's rework it to silence CodeQL warning anyway.

Files

Download all files
0040-mapgenerator4-Fix-CodeQL-bad-oddness-check-warning.patch (932 Bytes) 0040-mapgenerator4-Fix-CodeQL-bad-oddness-check-warning.patch main Marko Lindqvist, 02/08/2024 04:39 AM
0027-mapgenerator4-Fix-CodeQL-bad-oddness-check-warning.patch (1.2 KB) 0027-mapgenerator4-Fix-CodeQL-bad-oddness-check-warning.patch S3_2, S3_1 Marko Lindqvist, 02/08/2024 04:39 AM
Actions
Copy link

Also available in: Atom PDF