Feature #2449
open
Add SDL3 client in MacOS appbundle building script
Added by Jan Szurek about 23 hours ago.
Updated about 11 hours ago.
Description
Variant of homebrew-appbundle.sh: GTK4 and SDL3 clients, libraries bundled inside the packages. Output in dist:
Freeciv.app GTK4 client
Freeciv [SDL3].app SDL3 client
Freeciv Server.app Terminal launcher for the server from Freeciv.app
Freeciv-GTK4-<version>.dmg Freeciv.app and Freeciv Server.app
Freeciv-SDL3-<version>.dmg Freeciv [SDL3].app and Freeciv Server.app
Files
Related issues
1 (1 open — 0 closed)
- Blocked by Feature #2406: homebrew-appbundle-gtk4-dmg.sh: Branch specific followtag for non-release branches added
Let's get #2406 handled first, and I think it will dictate a bit different version of this patch for S3_3/main.
First one is a bit vague, as I didn't design exact changes myself:
- It seems like there's code duplicated between builds of gtk4-client and sdl3-client that should be refactored to be there only once. Maybe implemented as shell function(s)
- As the file gets renamed, its new name should be used in the list of files to include in the release (platforms/Makefile.am) and as a script for mac-appbundle job to run (.github/workflows/ci.yml)
- mac-appbundle job likely needs also an update to the list of dependencies to install
Also available in: Atom
PDF