Project

General

Profile

Actions

Bug #304

closed

UNIT and CITY only 16 bits in network protocol

Added by Marko Lindqvist 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Category:
General
Target version:
Start date:
03/12/2024
Due date:
% Done:

0%

Estimated time:

Description

Seen with savegame from Debian Bug report 1066100, and likely the root cause of the issue reported there. Reporter is Giacomo Mulas.

We try to support city and unit ids bigger than 65535. But network protocol still defines UNIT and CITY as 16 bit values, breaking things.

Easy to fix on S3_2 and main branches. Not so easy in S3_1, with optional capability, as there's quite many places in the protocol that needs the optional handling. Targeting 3.1.1 regardless.


Files

Actions #1

Updated by Marko Lindqvist 4 months ago

Patch suitable for S3_2 and main branches, where network protocol is not frozen, attached. Confirmed in S3_2 that this fixes original issues reported to Debian.

Actions #2

Updated by Marko Lindqvist 4 months ago

Actions #3

Updated by Marko Lindqvist 4 months ago

  • Status changed from In Review to Closed
Actions

Also available in: Atom PDF