Project

General

Profile

Actions
Copy link

Bug #304

closed

UNIT and CITY only 16 bits in network protocol

Added by Marko Lindqvist 8 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Marko Lindqvist
Category:
General
Target version:
3.1.1
Start date:
03/12/2024
Due date:
% Done:

0%

Estimated time:

Description

Seen with savegame from Debian Bug report 1066100, and likely the root cause of the issue reported there. Reporter is Giacomo Mulas.

We try to support city and unit ids bigger than 65535. But network protocol still defines UNIT and CITY as 16 bit values, breaking things.

Easy to fix on S3_2 and main branches. Not so easy in S3_1, with optional capability, as there's quite many places in the protocol that needs the optional handling. Targeting 3.1.1 regardless.

Files

Download all files
0022-Make-city-and-unit-ids-uint32-in-network-protocol.patch (1.3 KB) 0022-Make-city-and-unit-ids-uint32-in-network-protocol.patch main, S3_2 Marko Lindqvist, 03/12/2024 10:14 PM
0022-Make-city-and-unit-ids-uint32-in-network-protocol.patch (1.3 KB) 0022-Make-city-and-unit-ids-uint32-in-network-protocol.patch S3_1 Marko Lindqvist, 03/13/2024 02:13 AM
Actions
Copy link

Also available in: Atom PDF