Project

General

Profile

Actions
Copy link

Bug #335

closed

announce_trade_route_removal() call with a NULL city

Added by Marko Lindqvist 7 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Marko Lindqvist
Category:
Server
Target version:
3.1.1
Start date:
03/22/2024
Due date:
% Done:

0%

Estimated time:

Description

remove_trade_route() calls announce_trade_route_removal() even if the partner city is NULL. announce_trade_route_removal() expects both ends to be non-NULL.

I don't think that partner city can ever be NULL in remove_trade_route(), but it's already checking against it, so should be consistent.

Files

0018-Avoid-announce_trade_route_removal-call-with-a-NULL-.patch (1.56 KB) 0018-Avoid-announce_trade_route_removal-call-with-a-NULL-.patch Marko Lindqvist, 03/22/2024 03:01 AM
Actions
Copy link

Also available in: Atom PDF