Actions
Feature #527
closedgenerate_packets.py: always pass packet names separately from Locations
Start date:
05/02/2024
Due date:
% Done:
0%
Estimated time:
Description
Currently, referring to fields in the right packet struct is done inconsistently; sometimes the field type methods prepend hard-coded "real_packet->" and "old->", sometimes it's passed in as part of the Location, and sometimes (in the one case where it's necessary) the packet names are passed in separately and correctly assembled inside the function. Make all field type methods work the latter way.
Files
Updated by Alina Lenk 7 months ago
- File 0001-generate_packets.py-always-pass-packet-names-to-fiel.patch 0001-generate_packets.py-always-pass-packet-names-to-fiel.patch added
- Status changed from New to In Review
This also happens to fix a long-slumbering bug (bitvector put reading from packet instead of real_packet) that would've become an issue if we'd ever modified a bit vector inside a pre-send hook.
Actions