Freeciv Ticket System

08/27/2026

11:34 AM Freeciv Bug #2161: Heap buffer overflow in worklist_load() via unbounded wl_length from save file -- overwrites struct city fields including pointers (CVSS 8.8)

Looks good to me. Alina Lenk

08/25/2026

09:09 PM Freeciv Bug #2161: Heap buffer overflow in worklist_load() via unbounded wl_length from save file -- overwrites struct city fields including pointers (CVSS 8.8)

Makes sense. +1 for the else if option, then. Alina Lenk

09:03 PM Freeciv Bug #2161: Heap buffer overflow in worklist_load() via unbounded wl_length from save file -- overwrites struct city fields including pointers (CVSS 8.8)

Well no; the original patch caps wlist_max_length at MAX_LEN_WORKLIST, so the case where it's still greater than that... Alina Lenk

08:35 PM Freeciv Bug #2161: Heap buffer overflow in worklist_load() via unbounded wl_length from save file -- overwrites struct city fields including pointers (CVSS 8.8)

Could even drop the else; just two separate ifs, for the case where wlist_max_length is itself too big. Though they'd... Alina Lenk

06:46 PM Freeciv Bug #2161: Heap buffer overflow in worklist_load() via unbounded wl_length from save file -- overwrites struct city fields including pointers (CVSS 8.8)

For all branches except S2_6: AIUI the @wlist_max_length@ is just for reading/ignoring all the remaining (empty) entr... Alina Lenk

07:03 PM Freeciv Bug #2162: Out-of-bounds read in activities.order[] indexing -- missing bounds check that all other .order[] accesses have (CVSS 7.1)

All looks good. Alina Lenk

04/04/2025

01:16 PM Freeciv Bug #1227: generate_packets.py: DeprecationWarning: pathlib.PurePath.is_reserved()

I would just remove the check entirely; it's unlikely to ever do anything in practice, and if it does, it only makes ... Alina Lenk

10/20/2024

11:11 AM Freeciv Bug #975 (Closed): generate_packets.py failure on mac-meson CI job

Alina Lenk

10/18/2024

10:13 PM Freeciv Bug #975 (In Review): generate_packets.py failure on mac-meson CI job

Alina Lenk wrote in #note-6:
> Turns out this isn't the _only_ issue under Python 3.13
Nope, nevermind, I just ha... Alina Lenk

10:09 PM Freeciv Bug #975 (New): generate_packets.py failure on mac-meson CI job

Turns out this isn't the _only_ issue under Python 3.13 Alina Lenk