Actions
Feature #601
closedRename requirement type "UnitFlag" as "UnitTypeFlag"
Start date:
05/12/2024
Due date:
% Done:
0%
Estimated time:
Description
In case we later introduce unit instance flags, "UnitFlag" requirement type should be renamed as "UnitTypeFlag". We already have "UnitClassFlag", so this would also already be more consistent naming.
Files
Updated by Marko Lindqvist 6 months ago
- Blocks Tasks #397: S3_2 datafileformat freeze (d3f) added
Updated by Marko Lindqvist 6 months ago
- File 0087-Rename-requirement-type-UnitFlag-as-UnitTypeFlag.patch 0087-Rename-requirement-type-UnitFlag-as-UnitTypeFlag.patch added
- Status changed from New to In Review
- Assignee set to Marko Lindqvist
- Target version changed from 3.2.0-d3f to 3.3.0-d3f
While the change is simple, it requires a lot of work to do those simple changes everywhere. Thus:
1) Retarget to S3_3. It's enough to do this for one branch, without going through the pain of backporting to older branch
2) Instead of one big patch, go through migration period where both old and new name are accepted
Attached patch begins such a migration period. Supplied rulesets are not changed, but still use the old name.
Updated by Marko Lindqvist 6 months ago
- Blocks deleted (Tasks #397: S3_2 datafileformat freeze (d3f))
Updated by Marko Lindqvist 6 months ago
- Related to Feature #604: civ2civ3: Replace "UnitFlag" with "UnitTypeFlag" added
Updated by Marko Lindqvist 6 months ago
- Related to Feature #605: End "UnitFlag" -> "UnitTypeFlag" migration period added
Updated by Marko Lindqvist 6 months ago
- Related to deleted (Feature #604: civ2civ3: Replace "UnitFlag" with "UnitTypeFlag")
Updated by Marko Lindqvist 6 months ago
- File 0068-Rename-requirement-type-UnitFlag-as-UnitTypeFlag.patch 0068-Rename-requirement-type-UnitFlag-as-UnitTypeFlag.patch added
- Fix existing 3.2 -> 3.3 conversions that add User Unit Type Flags.
Updated by Marko Lindqvist 5 months ago
- File 0006-Rename-requirement-type-UnitFlag-as-UnitTypeFlag.patch 0006-Rename-requirement-type-UnitFlag-as-UnitTypeFlag.patch added
- Rebased
Actions