Freeciv

Here I want to change api_game_methods.[ch], is NULL->nullptr change close there?

api_game_methods.[ch] nullptr patch has not yet been made, so feel free to make this patch first.

#1399 is currently targeted to S3_3, related to my comment there that we might want to have lua api for regular specialists also in the older branch. This ticket is now targeted to S3_4. Which one we should change?

Marko Lindqvist wrote in #note-3:

#1399 is currently targeted to S3_3, related to my comment there that we might want to have lua api for regular specialists also in the older branch. This ticket is now targeted to S3_4. Which one we should change?

This patch would well go to S3_3 and editing API from #1399 may be left for S3_4. It's not much useful without superspecialists.

Please use nullptr instead of NULL, especially in api_game_find.c that is already otherwise unified to nullptr.

nullptr can be used in code that is not going to branches older than S3_3. For patches that are going also to older branches, we still have to use NULL (or to make separate patch for newer branches)

Marko Lindqvist wrote in #note-7:

Please use nullptr instead of NULL, especially in api_game_find.c that is already otherwise unified to nullptr.

nullptr can be used in code that is not going to branches older than S3_3. For patches that are going also to older branches, we still have to use NULL (or to make separate patch for newer branches)

Understood. Have you applied api_game_find patch to the repo?

Alexandr Ignatiev wrote in #note-8:

Understood. Have you applied api_game_find patch to the repo?

git log origin/main common/scriptcore/api_game_find.c

commit 3b77a0ea701e9ec023b61526dbdc063d977ced16
Author: Marko Lindqvist <cazfi74@gmail.com>
Date: Sat May 3 11:13:08 2025 +0300

api_game_find.c: Replace NULL with nullptr

See RM #1361

Signed-off-by: Marko Lindqvist <cazfi74@gmail.com>