Bug #1672
openQt client - Help menu items disappear
0%
Description
After you open the help dialog once and close it, some of the Help menu items disappear.
See before/after screenshots. This is a real puzzler.
Files
| qt_1st.png (81.4 KB) qt_1st.png | |||
| qt_2nd.png (64.6 KB) qt_2nd.png | |||
| 1672.patch (2.03 KB) 1672.patch | |||
| 1672_S3_1.patch (1.72 KB) 1672_S3_1.patch |
Updated by Dean Brown 24 days ago
- File 1672.patch added
And then I realized the disappearing menu items all begin with "About...", and remembered a previous problem with qt moving the "Options..." menu item to where qt thinks it should go according to the Mac standard UI guidelines. And the same kind of workaround fixes this one too.
Patch should be good for all branches.
Updated by Marko Lindqvist 6 days ago
- Style: Empty line between variable declarations and code
- In branches that have it, use fc_strncmp() instead of strncmp()
Updated by Marko Lindqvist 6 days ago
- Those new entries in helpdlg_g.h should not use N_() macro. We don't want them to pollute .po files.
In general I'm worried about how translation system works with this, but can't dive in to it now (where the translation happens and what string it's applied for?)
Updated by Dean Brown 5 days ago
- File 1672.patch 1672.patch added
Translation issues hadn't occurred to me, but after thinking about it awhile I wondered if there's a better way. Searching StackOverflow I found there's a way to tell qt to not move the menu items. So this is a much cleaner fix - doesn't affect translations, and keeps the changes localized within .../client/gui-qt and out of common code.
Unfortunately the same type of fix doesn't work for the previous problem with qt moving the "Options..." sub-menu item, I guess because that's a sub-menu, so have to leave that old fix as is.
Patch should be good for all branches.
Updated by Marko Lindqvist 5 days ago
- Status changed from New to In Review
- Assignee set to Marko Lindqvist
- Target version set to 3.2.2
Updated by Marko Lindqvist 5 days ago
Does S3_1 need patching for the "About Freeciv" item?
Updated by Dean Brown 4 days ago
- File 1672_S3_1.patch 1672_S3_1.patch added
version 3.1.5 has the bug. Needs a different patch because the line numbers don't line up. This could go into 3.1.6
Updated by Marko Lindqvist 4 days ago
- Target version changed from 3.2.2 to 3.1.6