Bug #1792
openinconsistent reporting of one time bonus and revenues
0%
Description
Only happens when caravan_bonus_style = CLASSIC, which is the default.
Client says -
"Your Caravan ... reaches the city ...", "Enter Marketplace (109 one time bonus...)"
Server says -
"Your Caravan ... has arrived ... revenues amount to 119 in gold and research."
Cause is in common/traderoutes.c routine get_caravan_enter_city_trade_bonus() this line
tb = (tb * (pc1->surplus[O_TRADE] + pc2->surplus[O_TRADE])) / 24;
When called from the client, foreign city's surplus is unknown (=0), so the
client should say "estimated".
Files
Updated by Marko Lindqvist 11 days ago
Should it be "estimated" only if the target city is a foreign one? For domestic trade routes client knows both ends' trade surplus.
Updated by Marko Lindqvist 11 days ago
- Status changed from New to In Review
- Assignee set to Marko Lindqvist
- Target version set to 3.2.2
I've recently written documentation of the commit message rules: https://www.freeciv.org/wiki/Commit_rules#Commit_message
It would be nice if you followed that format in your future patches (no need to update any of the existing ones, I've already update d the commit messages when I've taken them to my work trees)