Actions
Bug #1792
openinconsistent reporting of one time bonus and revenues
Start date:
12/01/2025
Due date:
% Done:
0%
Estimated time:
Description
Only happens when caravan_bonus_style = CLASSIC, which is the default.
Client says -
"Your Caravan ... reaches the city ...", "Enter Marketplace (109 one time bonus...)"
Server says -
"Your Caravan ... has arrived ... revenues amount to 119 in gold and research."
Cause is in common/traderoutes.c routine get_caravan_enter_city_trade_bonus() this line
tb = (tb * (pc1->surplus[O_TRADE] + pc2->surplus[O_TRADE])) / 24;
When called from the client, foreign city's surplus is unknown (=0), so the
client should say "estimated".
Files
Actions