Bug #1793
openNull government causing crash
0%
Description
I'm using my personal ruleset for v3.2:
https://raw.githubusercontent.com/dftec-es/civ2civ3_earth/master/3.2/civ2civ3_earth-3.2.mpdl
The error log is:
in government_name_translation() [government.c::145]: assertion '((void *)0) != pgovern' failed.
I attach a savegame that crashes when I load it with QT client.
It might be related to the fact that I lost contact with the Romans, but there is an open diplomatic dialog with them, that I have not closed for some turns.
GTK loads the savegame, but the nations tab shows that Romans have government "null".
If I move the egyptian trireme (in the mediterranean sea) to a tile adjacent to the roman city, to gain contact with them again, and then I try to open a diplomatic dialog with the Romans, then the client crashes with the same error.
Files
Updated by David Fernandez 12 days ago
I forgot to say that I'm playing on freeciv v3.2.1+ (as it was some days ago).
I just pulled and compiled the latest changes until today, and now the qt client behave the same as gtk: it loads the savegame, but it crashes when I contact with the romans and open a diplomatic dialog.
Updated by Marko Lindqvist 11 days ago
- File 0052-Send-info-about-the-other-player-when-re-establishin.patch 0052-Send-info-about-the-other-player-when-re-establishin.patch added
- Category set to Server
- Status changed from New to In Review
- Assignee set to Marko Lindqvist
- Target version set to 3.2.2
Here's a fix for the server to resend government info of the other player when connection is re-established.
For S3_2 we should also make some kind of client side fix/workaround for cases where it's connected to an older server without this server fix, but that might happen in a separate ticket.
Updated by David Fernandez 11 days ago
The patch seems to fix it, thank you.
It was an error that I used to see often in my test games, and with the patch I have not seen it again.