Feature #943
opengtk: Menu entries for zoom
0%
Description
In a https://osdn.net/projects/freeciv/ticket/42457 comment alain_bkr requests menu entries for zoom.
Files
Updated by Dean Brown 10 months ago
I think I can do this one, for qt, gtk3.22, gtk4 & gtk5 clients. But better to wait until #1292 is done because of collisions.
Updated by Marko Lindqvist 10 months ago
- Blocked by Feature #1292: gtk clients on Mac - use meta key instead of ctrl key for menu accelerator keys added
Updated by Dean Brown 9 months ago
The qt client already has zoom menu items.
It turns out that gtk will not let you use "+" or "-" keys by themselves as menu accelerator keys. In gtk3.22 they just don't work, gtk4 gives an error message. Combining one of them with Ctrl or Meta seems OK, the View menu item Show Stack Size uses Ctrl/Meta and "+". There's really no other menu accelerator keys that are suitable. I could add zoom in and zoom out menu items without menu accelerator keys, but then would want to leave in the current functionality of having "+" or "-" keys do zooming. So wondering if it's worthwhile.
Updated by Dean Brown 9 months ago
- File 943-S3_1+S3_2.patch added
- File 943-S3_3+Main.patch added
Should have read the GTK documentation first, turns out "+" or "-" keys do work if you do it correctly.
Updated by Marko Lindqvist 4 months ago
- Target version set to 3.3.0
Indentation of some function parameters is off.
Updated by Marko Lindqvist 3 months ago
- Status changed from New to In Progress
- Assignee set to Dean Brown
Updated by Marko Lindqvist 25 days ago
Ping.
I'd like to have freeciv-3.3 keys to be in their final shape by the S3_3-alpha3 release.
Updated by Dean Brown 22 days ago
- File 943_Main.patch 943_Main.patch added
- File 943_S3_2.patch 943_S3_2.patch added
- File 943_S3_3.patch 943_S3_3.patch added
Thanks for the ping, I didn't realize this was still pending.
The old patches no longer applied, so had to do new ones.
Some files had trailing spaces and formatting issues with tabs - fixed.