Actions
Feature #943
opengtk: Menu entries for zoom
Start date:
10/09/2024
Due date:
% Done:
0%
Estimated time:
Description
In a https://osdn.net/projects/freeciv/ticket/42457 comment alain_bkr requests menu entries for zoom.
Files
Actions
Added by Marko Lindqvist over 1 year ago. Updated 2 months ago.
0%
Description
In a https://osdn.net/projects/freeciv/ticket/42457 comment alain_bkr requests menu entries for zoom.
Files
| 943-S3_1+S3_2.patch (7.61 KB) 943-S3_1+S3_2.patch | Dean Brown, 06/05/2025 06:43 AM | ||
| 943-S3_3+Main.patch (11.4 KB) 943-S3_3+Main.patch | Dean Brown, 06/05/2025 06:43 AM |
I think I can do this one, for qt, gtk3.22, gtk4 & gtk5 clients. But better to wait until #1292 is done because of collisions.
The qt client already has zoom menu items.
It turns out that gtk will not let you use "+" or "-" keys by themselves as menu accelerator keys. In gtk3.22 they just don't work, gtk4 gives an error message. Combining one of them with Ctrl or Meta seems OK, the View menu item Show Stack Size uses Ctrl/Meta and "+". There's really no other menu accelerator keys that are suitable. I could add zoom in and zoom out menu items without menu accelerator keys, but then would want to leave in the current functionality of having "+" or "-" keys do zooming. So wondering if it's worthwhile.
Should have read the GTK documentation first, turns out "+" or "-" keys do work if you do it correctly.
Indentation of some function parameters is off.