Bug #1227: generate_packets.py: DeprecationWarning: pathlib.PurePath.is_reserved() - Freeciv - Freeciv Ticket System

Actions

Copy link

Bug #1227

closed

generate_packets.py: DeprecationWarning: pathlib.PurePath.is_reserved()

Added by Marko Lindqvist 3 months ago. Updated 13 days ago.

Status:

Closed

Priority:

Normal

Assignee:

Marko Lindqvist

Category:

Bootstrap

Target version:

3.2.0-RC1

Start date:

01/27/2025

Due date:

% Done:

Estimated time:

Description

[6/781] Generating packets_server with a custom command
/fast/freeciv/S3_2/builds/mall32/../../src/common/generate_packets.py:46: DeprecationWarning: pathlib.PurePath.is_reserved() is deprecated and scheduled for removal in Python 3.15. Use os.path.isreserved() to detect reserved paths on Windows.
if path.is_reserved() or not path.name:
[12/781] Generating packets_client with a custom command
/fast/freeciv/S3_2/builds/mall32/../../src/common/generate_packets.py:46: DeprecationWarning: pathlib.PurePath.is_reserved() is deprecated and scheduled for removal in Python 3.15. Use os.path.isreserved() to detect reserved paths on Windows.
if path.is_reserved() or not path.name:
[14/781] Generating packets_common with a custom command
/fast/freeciv/S3_2/builds/mall32/../../src/common/generate_packets.py:46: DeprecationWarning: pathlib.PurePath.is_reserved() is deprecated and scheduled for removal in Python 3.15. Use os.path.isreserved() to detect reserved paths on Windows.
if path.is_reserved() or not path.name:

Files

Download all files

0031-generate_packets.py-Fix-deprecated-pathlib.PurePath..patch (1.65 KB) 0031-generate_packets.py-Fix-deprecated-pathlib.PurePath..patch	main, S3_3	Marko Lindqvist, 04/03/2025 06:37 PM
0017-generate_packets.py-Fix-deprecated-pathlib.PurePath..patch (1.65 KB) 0017-generate_packets.py-Fix-deprecated-pathlib.PurePath..patch	S3_2	Marko Lindqvist, 04/03/2025 06:37 PM
0031-Remove-deprecated-pathlib.PurePath.is_reserved-usage.patch (1.48 KB) 0031-Remove-deprecated-pathlib.PurePath.is_reserved-usage.patch	main, S3_3	Marko Lindqvist, 04/05/2025 11:07 AM
0017-Remove-deprecated-pathlib.PurePath.is_reserved-usage.patch (923 Bytes) 0017-Remove-deprecated-pathlib.PurePath.is_reserved-usage.patch	S3_2	Marko Lindqvist, 04/05/2025 11:08 AM

Actions

Copy link Download all files

Updated by Marko Lindqvist 27 days ago

File 0031-generate_packets.py-Fix-deprecated-pathlib.PurePath..patch 0031-generate_packets.py-Fix-deprecated-pathlib.PurePath..patch added
File 0017-generate_packets.py-Fix-deprecated-pathlib.PurePath..patch 0017-generate_packets.py-Fix-deprecated-pathlib.PurePath..patch added
Status changed from New to In Review
Assignee set to Marko Lindqvist
Target version set to 3.2.0-RC1

Actions

Copy link

Updated by Alina Lenk 26 days ago

I would just remove the check entirely; it's unlikely to ever do anything in practice, and if it does, it only makes the script exit a little earlier; it's not preventing any actual issue that would have repercussions. I originally added it mostly just because it technically did something useful and was trivial to do while remaining platform-agnostic, not because it would be necessary.

Actions

Copy link Download all files