Feature #1287: GTK client remember size of help dlg - Freeciv - Freeciv Ticket System

Actions

Copy link

Feature #1287

closed

GTK client remember size of help dlg

Added by Dean Brown 10 months ago. Updated 9 months ago.

Status:

Closed

Priority:

Normal

Assignee:

Marko Lindqvist

Category:

gtk3.22-client

Target version:

3.1.6

Start date:

04/06/2025

Due date:

% Done:

Estimated time:

Description

This has bothered me ever since I first started with freeciv many years ago - having to always enlarge the help dlog. The qt client tracks its size already. I figured out how to do it for gtk3.22 (and gtk3, not that it matters), gtk4 does things differently.

Files

Download all files

#1287-3.1.patch (2.64 KB) #1287-3.1.patch		Dean Brown, 04/06/2025 07:30 AM
#1287-main.patch (13.8 KB) #1287-main.patch		Dean Brown, 04/06/2025 07:30 AM
1287gtk4-1time.patch (1.68 KB) 1287gtk4-1time.patch		Dean Brown, 04/13/2025 06:00 AM
1287gtk4-alltime.patch (1.46 KB) 1287gtk4-alltime.patch		Dean Brown, 04/13/2025 06:00 AM
1287gtk5-alltime.patch (1.46 KB) 1287gtk5-alltime.patch		Dean Brown, 04/16/2025 01:55 AM
1287combined.patch (16.1 KB) 1287combined.patch		Dean Brown, 05/04/2025 11:35 PM
1287corrected.patch (7.92 KB) 1287corrected.patch		Dean Brown, 05/20/2025 11:30 PM
1287-S3_1&S3_2corrected.patch (2.9 KB) 1287-S3_1&S3_2corrected.patch		Dean Brown, 05/25/2025 03:52 AM
1287-S3_3&MainCorrected.patch (11.7 KB) 1287-S3_3&MainCorrected.patch		Dean Brown, 05/26/2025 07:56 AM
1287-S3_3&MainCorrectedWithMigrate.patch (13.2 KB) 1287-S3_3&MainCorrectedWithMigrate.patch		Dean Brown, 05/28/2025 06:28 AM

Related issues 1 (0 open — 1 closed)

Actions

Copy link Download all files

Updated by Dean Brown 10 months ago

File #1287-3.1.patch #1287-3.1.patch added
File #1287-main.patch #1287-main.patch added

The 3.1 patch only remembers the size during one runtime. To remember it across runtimes requires storing the value in the options file freeciv-client-rc-xxx. Because we are so close to the 3.2.0 release and that data file formats are frozen and that the options file counts as a data file format, I did that patch for the main branch. I could be wrong, maybe it's OK to apply the main patch to 3.2?

Actions

Copy link Download all files

Updated by Dean Brown 10 months ago

File 1287gtk4-1time.patch 1287gtk4-1time.patch added
File 1287gtk4-alltime.patch 1287gtk4-alltime.patch added

Figured out the fix for gtk4.

The 1time patch made from 3.1 branch, doesn't touch freeciv-client-rc-* file, saves the size during one runtime.

The alltime patch made from main branch, affects freeciv-client-rc-* file, saves the size across runtimes. This patch was created after the patch "#1287-main.patch" was done.

Actions

Copy link

Updated by Dean Brown 10 months ago

File 1287gtk5-alltime.patch 1287gtk5-alltime.patch added

copy the fix into gtk5

Actions

Copy link

Updated by Marko Lindqvist 10 months ago

Target version set to 3.1.6

Actions

Copy link

Updated by Dean Brown 9 months ago

File 1287combined.patch 1287combined.patch added

Replace the files #1287-main.patch, 1287gtk4-alltime.patch and 1287gtk5-alltime.patch with 1287combined.patch

Actions

Copy link

Updated by Marko Lindqvist 9 months ago

Can you provide single patch for S3_1/S3_2 too.

You should not add new options for already removed clients.

Actions

Copy link

Updated by Dean Brown 9 months ago

File 1287corrected.patch 1287corrected.patch added

I did not test this corrected patch on S3_1 but expect it to be OK.

Actions

Copy link

Updated by Marko Lindqvist 9 months ago

Dean Brown wrote in #note-7:

I did not test this corrected patch on S3_1 but expect it to be OK.

This now adds options to the client .rc file. Not correct for S3_1 or S3_2.

Actions

Copy link

Updated by Dean Brown 9 months ago

File 1287-S3_1&S3_2corrected.patch 1287-S3_1&S3_2corrected.patch added

Corrected patch for S3_1 & S3_2

Actions

Copy link

#10

Updated by Marko Lindqvist 9 months ago

Blocks Feature #1288: GTK client remember size of the options dlog added

Actions

Copy link

#11

Updated by Marko Lindqvist 9 months ago

Marko Lindqvist wrote in #note-6:

You should not add new options for already removed clients.

There's still no S3_3/main patch that corrects this, right?

Actions

Copy link

#12

Updated by Dean Brown 9 months ago

File 1287-S3_3&MainCorrected.patch 1287-S3_3&MainCorrected.patch added

Now there is.

Actions

Copy link

#13

Updated by Marko Lindqvist 9 months ago

S3_3/main patch needs code for migrating options from client to client when user switches to a newer gtk version. migrate_options_from_gtk3_22() in gtk4-client, migrate_options_from_gtk3_22() and migrate_options_from_gtk4() in gtk4x-client.

Actions

Copy link

#14