Bug #1489
open
handle_edit_key_press() not directing Mac Meta -combinations to main key handler
Added by Marko Lindqvist 9 days ago.
Updated 42 minutes ago.
Description
The code in question was already mentioned in https://redmine.freeciv.org/issues/1292#note-9 where my concern was dismissed, but I still (or again) think it needs changing. Otherwise Mac does not make early exit (with return FALSE) when Meta is being held.
This is a regression since 3.1.5 and 3.2.0-beta2.
Files
Related issues
1 (1 open — 0 closed)
Related part of documentation from the keys spreadsheet.
- Priority changed from Normal to Blocker
Marko Lindqvist wrote:
This is a regression since 3.1.5 and 3.2.0-beta2.
Setting priority accordingly.
Good catch. Fix in editgui.c means 2 files need the macro for platform specific menu accelerator modifier keys, so I moved it to gui_main.h
S3_3/main patch adds a file called 1489-S3_1+S3_2.patch
1489-S3_1+S3_2.patch | 143 +++++++++++++++++++++++++++++++
...
diff --git a/1489-S3_1+S3_2.patch b/1489-S3_1+S3_2.patch
new file mode 100644
index 0000000000..fd609b4d59
--- /dev/null
+++ b/1489-S3_1+S3_2.patch
...
Maybe also try to write more standard form commit messages, so it would be less work to rewrite them before applying them to my work tree. Currently you have just a very long subject line. Make that shorter than 70 characters, and write the longer story to the body of the message (after one empty line). Subject line should also be in imperative form, optionally prefixed by the "location" of the change, e.g., "gtk: " or "handle_edit_key_press(): "
See 'git log' for examples.
- Status changed from New to In Progress
- Assignee set to Dean Brown
This is currently the only 3.2.0 blocker (See #1309) that is not yet "In Review"
Also available in: Atom
PDF
