Project

General

Profile

Actions

Bug #1693

open

SIGSEGV in begin_phase from autoattack loss.

Added by John Robertson 16 days ago. Updated 12 days ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Server
Target version:
Start date:
09/23/2025
Due date:
% Done:

0%

Estimated time:

Description

[3.3.90.5-dev]
During the begin_phase, an autoattack from movement can delete a unit that is later accessed after being freed.

  • Added 'alive' checks after the unit delete to guard against use of deleted pointer.
  • Corrected the return value of adv_follow_path() to return FALSE when the unit had been deleted, instead of returning TRUE, which encouraged use of deleted pointer.
  • Moved the processing for unit_attack_civilian_casualties(), which dereferences the unit pointer ahead of kill_unit() call that deletes the unit.

Files

1693.patch (2.93 KB) 1693.patch John Robertson, 09/23/2025 10:19 AM
1693.v2.patch (4.01 KB) 1693.v2.patch John Robertson, 09/27/2025 05:32 AM
Actions

Also available in: Atom PDF