Freeciv

Dean Brown wrote in #note-4:

Can a tile really be not visible to its owner? Did not think of that, and I'm not sure. Whatever, easy to accommodate - here's better patches.

This forgets the original "TODO" that you were set to fix. The "rumor" system does not work when the borders are disabled.

Borders extend from cities far further than city vision range, so it's common situation that owner does not see some tiles. Unless you have set 'borders' to SEE_INSIDE or EXPAND.

So I think we continue with the original patches (that's what I'm going to push if nobody disagrees)

I prefer the better patches - adds to the existing functionality instead of replacing it. But I'm OK either way.

Dean Brown wrote in #note-7:

I prefer the better patches - adds to the existing functionality instead of replacing it. But I'm OK either way.

Then they need to be updated to address the original TODO issue, or at least the TODO comment should not be removed if it's not addressed.

The "rumor" system does not work when the borders are disabled.

Are you referring to this call in create_barbarian_player()?

  notify_player(NULL, NULL, E_UPRISING, ftc_server,
                _("%s gain a leader by the name %s. Dangerous " 
                  "times may lie ahead."),
                nation_plural_for_player(barbarians),
                player_name(barbarians));

Interpreting that comment is a bit unclear -
1 The comparison to barbarian uprising isn't good because barbarian uprisings get announced to all players regardless of tile or disabled borders.
2 What does "nearby" mean exactly? If "nearby" means adjacent or visible, then tile_is_seen() is true and it gets announced, and the comment is addressed. If it means "up to num tiles away" then I'm not sure if it's a good idea to announce about a tile that is neither owned nor visible. But that's assuming tile_is_seen() is not affected by disabled borders - my testing seems to show that's true.