Freeciv

John Robertson wrote:

Looking at the coredump, it is clear that `game_city_by_number(city_id)` returns nullptr.

The `city_id` seemed to be out of range.

Even if that was not what happened to you, I think it's quite possible that a city gets destroyed while the dialog is open, leading to such a segfault.

Marko Lindqvist wrote in #note-2:

John Robertson wrote:

Looking at the coredump, it is clear that `game_city_by_number(city_id)` returns nullptr.

The `city_id` seemed to be out of range.

Even if that was not what happened to you, I think it's quite possible that a city gets destroyed while the dialog is open, leading to such a segfault.

Yes, I have seen a conquered enemy city stay in the gotodlg list, not updated. E.g. the city doesn't switch sides, or a deleted city remains in the list until the next refresh.

Maybe the return should include a list refreash.

At least for the 3.2.2 release coming out soon (-> with limited testing time left) I still plan to go with the original minimal-risk patch. We can revisit this in the full 3.2.3 cycle.