Added by Bernhard M. Wiedemann 24 days ago. Updated 11 days ago.
0%
Description
While working on reproducible builds for openSUSE, I found that
our freeciv-3.2.5 package varied between builds from parts generated by tolua.
I attached a fix for main that allows bit-identical builds. Please review/merge.
Files
| 0001-tolua-Generate-deterministic-code.patch (32.7 KB) 0001-tolua-Generate-deterministic-code.patch | Bernhard M. Wiedemann, 08/06/2026 07:20 AM | ||
| 0045-tolua-Generate-deterministic-code.patch (33 KB) 0045-tolua-Generate-deterministic-code.patch | main | Marko Lindqvist, 08/08/2026 12:35 PM | |
| 0023-tolua-Generate-deterministic-code.patch (32.6 KB) 0023-tolua-Generate-deterministic-code.patch | S3_3, S3_2 | Marko Lindqvist, 08/08/2026 12:35 PM |
Do you have any idea of the root cause - why isn't the order (->tolua) deterministic and requires such "fixing"?
In lua and most other hash implementations, there is a random seed used for the hash indexing to mitigate an attack that sends elements crafted specifically to all hash into the same bucket which would DoS the software. The downside is that iteration order becomes as random as the seed.
So we need to sort when iterating to get stable ordering out.
And there was a date added.
- Backported to S3_3 & S3_2
- On all branches, did an additional round of building tolua + generating toluabind.c with it, so that the generated file comes from the updated version (and tolua of that branch)