Bug #596
closedMeson: packhand_gen.c depends on version_gen.h, but not set up so
0%
Description
[15/531] Compiling C object libfc_client_common.a.p/meson-generated_.._packhand_gen.c.obj
FAILED: libfc_client_common.a.p/meson-generated_.._packhand_gen.c.obj
"cc" "-Ilibfc_client_common.a.p" "-I." "-I../../../../../.." "-I../../../../../../dependencies/lua-5.4/src" "-I../../../../../../dependencies/luasql/src" "-I../../../../../../dependencies/tinycthread" "-I../../../../../../dependencies/tolua-5.2/include" "-I../../../../../../dependencies/cvercmp" "-I../../../../../../utility" "-I../../../../../../common" "-I../../../../../../common/networking" "-I../../../../../../common/scriptcore" "-I../../../../../../common/aicore" "-I../../../../../../client" "-I../../../../../../client/include" "-I../../../../../../client/luascript" "-I../../../../../../client/agents" "-fdiagnostics-color=always" "-D_FILE_OFFSET_BITS=64" "-Wall" "-Winvalid-pch" "-O0" "-g" "-Wno-nonnull-compare" "-Wnested-externs" "-Wall" "-Wmissing-declarations" "-Wpointer-arith" "-Wcast-align" "-Wmissing-prototypes" "-Wformat" "-Wformat-security" "-Wshadow" "-Wold-style-declaration" "-Wold-style-definition" "-Wtype-limits" "-Wimplicit-fallthrough" "-Wshadow" "-D_WIN32_WINNT=0x0A00" "-DHAVE_CONFIG_H" -MD -MQ libfc_client_common.a.p/meson-generated_.._packhand_gen.c.obj -MF "libfc_client_common.a.p/meson-generated_.._packhand_gen.c.obj.d" -o libfc_client_common.a.p/meson-generated_.._packhand_gen.c.obj "-c" packhand_gen.c
In file included from packhand_gen.c:9:
./fc_config.h:3:10: fatal error: version_gen.h: No such file or directory
3 | #include "version_gen.h"
| ^~~~~~~~~~~~~
compilation terminated.
Files
Updated by Marko Lindqvist 6 months ago
- File 0077-Meson-Make-pack_client-to-depend-on-verhdr.patch 0077-Meson-Make-pack_client-to-depend-on-verhdr.patch added
- File 0036-Meson-Make-pack_client-to-depend-on-verhdr.patch 0036-Meson-Make-pack_client-to-depend-on-verhdr.patch added
- Status changed from New to In Review
- Assignee set to Marko Lindqvist
Updated by Alina Lenk 6 months ago
Shouldn't it be client_common that depends on verhdr, rather than pack_client? pack_client is just generating packhand_gen.[ch], not compiling it. This way it might not even work (at least with lazy-overwrite); if verhdr changes, but after pack_client, it realizes packhand_gen.[ch] haven't changed, so it doesn't rebuild client_common.
Updated by Marko Lindqvist 6 months ago
- Blocks Feature #628: Msys2-next after 240406 added
Updated by Marko Lindqvist 6 months ago
- Blocks Feature #595: CI: setup-msys2 2.23.0 added
Updated by Marko Lindqvist 6 months ago
- File 0001-Meson-Make-fc_client_common-to-depend-on-verhdr.patch 0001-Meson-Make-fc_client_common-to-depend-on-verhdr.patch added
Alina Lenk wrote in #note-2:
Shouldn't it be client_common that depends on verhdr, rather than pack_client?
Yes. Attached version does that.