Actions
Feature #943
opengtk: Menu entries for zoom
Start date:
10/09/2024
Due date:
% Done:
0%
Estimated time:
Description
In a https://osdn.net/projects/freeciv/ticket/42457 comment alain_bkr requests menu entries for zoom.
Files
Actions
Added by Marko Lindqvist over 1 year ago. Updated about 1 month ago.
0%
Description
In a https://osdn.net/projects/freeciv/ticket/42457 comment alain_bkr requests menu entries for zoom.
Files
| 943_S3_2.patch (18.1 KB) 943_S3_2.patch | Dean Brown, 02/09/2026 03:13 AM | ||
| 943_Main.patch (17.5 KB) 943_Main.patch | Dean Brown, 02/09/2026 03:13 AM | ||
| 943_S3_3.patch (16.9 KB) 943_S3_3.patch | Dean Brown, 02/09/2026 03:13 AM |
I think I can do this one, for qt, gtk3.22, gtk4 & gtk5 clients. But better to wait until #1292 is done because of collisions.
The qt client already has zoom menu items.
It turns out that gtk will not let you use "+" or "-" keys by themselves as menu accelerator keys. In gtk3.22 they just don't work, gtk4 gives an error message. Combining one of them with Ctrl or Meta seems OK, the View menu item Show Stack Size uses Ctrl/Meta and "+". There's really no other menu accelerator keys that are suitable. I could add zoom in and zoom out menu items without menu accelerator keys, but then would want to leave in the current functionality of having "+" or "-" keys do zooming. So wondering if it's worthwhile.
Should have read the GTK documentation first, turns out "+" or "-" keys do work if you do it correctly.
Indentation of some function parameters is off.
Ping.
I'd like to have freeciv-3.3 keys to be in their final shape by the S3_3-alpha3 release.
Thanks for the ping, I didn't realize this was still pending.
The old patches no longer applied, so had to do new ones.
Some files had trailing spaces and formatting issues with tabs - fixed.