Feature #1292
closed
gtk clients on Mac - use meta key instead of ctrl key for menu accelerator keys
Added by Dean Brown 3 months ago.
Updated about 1 month ago.
Description
Mac standard is to use the "command"/"meta" key for the menu accelerator modifier key instead of ctrl key. The qt client already does this.
Files
Related issues
1 (1 open — 0 closed)
fix for gtk3.22 & gtk4.
The helpdata.txt file uses "Ctrl" throughout the Help -> Controls section, and I was going to fix that too, but it also includes things that are not menus. While digging into that I discovered it's an even worse can of worms because the same help text is used in the qt client where it's even more wrong. Filing a new issue #1293 for that.
For S3_3 & main, you should update also gui-gtk-5.0 (which is actually using gtk4 at the moment), at least to make similar change to gui-gtk-4.0 if you can't test gtk5-client. (Same comment for all gtk patches you've done)
- Target version set to 3.1.6
Can you provide a single patch for S3_3/main?
1292.patch should still be good for S3_1/S3_2.
- Status changed from New to In Review
- Assignee set to Marko Lindqvist
There's also an GDK_CONTROL_MASK check in handle_edit_key_press(). Feel free to open a new ticket about that, if you feel like it's something that needs addressing too.
Checked out the GDK_CONTROL_MASK in handle_edit_key_press(). It results in a call to handle_edit_key_press_with_ctrl(), which does nothing because there are no ctrl+[key] combinations used by edit mode. So nothing needs to be done. If someday a new ctrl+[key] combination is added to edit mode then it would become an issue.
Tangent - while working on #1293, I wanted a copy of the text from the [help_controls] section of the helpdata.txt file, but without the markup. So I ran a gtk client, did Help -> Controls, then selected all the text and copied it. With CMD+C, as it should be on the Mac, and it worked as it should. So gtk is handling that OK - that's not handled by freeciv code.
- Status changed from In Review to Closed
Also available in: Atom
PDF