Feature #1799
closed
API refactor - double pointer was never used; single pointer suffices.
Added by John Robertson 10 days ago.
Updated 9 days ago.
Description
unit_assign_specific_activity_target()
unit_activity_handling_targeted()
unit_activity_targeted_internal()
do_action_activity_targeted()
all use a double pointer for the extra_type structure, but only use it equivalently as a single pointer.
This patch refactors these APIs to use the more straightforward single pointer.
Files
unit_assign_specific_activity_target():
- *target = tgt;
+ target = tgt;
return;
The new assignment does nothing sensible. It just sets local variable just before the function returns. Old assignment set target on the caller side via the pointer.
...and at least action_sub_target_id_for_action() depended on that:
unit_assign_specific_activity_target(actor_unit, &activity,
- action_number(paction), &pextra);
+ action_number(paction), pextra);
if (pextra != NULL) {
- Status changed from New to Rejected
- Assignee set to Marko Lindqvist
Also available in: Atom
PDF