Freeciv

In many of those changed places the nullptr check should actually replace old DEFAULT_SPECIALIST check, not add to it, i.e., we want Entertainers (DEFAULT_SPECIALIST) to work correctly too.

Is the requirements.c change even related? Seems wrong in any case, as it does turn invalid (nullptr) specialist in to a valid one (first one / number zero) with no clear justification of why just that one gets selected.

My comment got mangled by -1 being interpreted as strike-thru.

Dean Brown wrote in #note-1:

When this done I will update/improve the 1618_Main.patch in #1618.

#1618 has been resolved already. Open a new ticket for the new change.

When client connects, server says:
1: Trying to put -1 into 8 bits; it will result 255 at receiving side.

Debugging revealed that this comes from packets_gen.c line

    e |= DIO_PUT(uint8, &d_out, &field_addr, real_packet->spectype_id);

Likely it's possible to simply change the data type to be sint8 in the network protocol.

Added change in packets.def