Project

General

Profile

Actions
Copy link

Bug #511

closed

json protocol: memory leak when discarding is-info packets

Added by Alina Lenk 7 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Alina Lenk
Category:
General
Target version:
3.2.0
Start date:
04/27/2024
Due date:
% Done:

0%

Estimated time:

Description

When an is-info packet contains no changes and is discarded, the send function returns early without freeing the packet's JSON object.

Either need to introduce a SEND_PACKET_DISCARD macro in packets[_json].h and use it to handle this, or delay SEND_PACKET_START until after we know the packet won't be discarded (which would reduce the simplicity gains from #510).

Files

Download all files
S3_2-json-protocol-free-json-object-when-discarding-info-.patch (2.07 KB) S3_2-json-protocol-free-json-object-when-discarding-info-.patch S3_2 Alina Lenk, 04/30/2024 01:47 PM
main-json-protocol-free-json-object-when-discarding-info-.patch (2.05 KB) main-json-protocol-free-json-object-when-discarding-info-.patch main Alina Lenk, 04/30/2024 01:47 PM
Actions
Copy link

Also available in: Atom PDF