Freeciv

This should probably document the new flag in the rulesets / comments.txt.

I'm not sure about making it a ruleset error to have a Convert improvement that does nothing; in a ruleset where no other Convert production is available in the beginning, we might still want a way to not produce anything else. Plus there could (theoretically) be scripts checking what's being produced.

Alina Lenk wrote in #note-2:

I'm not sure about making it a ruleset error to have a Convert improvement that does nothing; in a ruleset where no other Convert production is available in the beginning, we might still want a way to not produce anything else. Plus there could (theoretically) be scripts checking what's being produced.

I don't think the codebase is ready for convert genus building that's not actually producing anything. It's the targets "Gold" (and with this patch "Infra") that eat up the production so it does not accumulate towards a building, not the Convert genus. I don't know what would happen if you would let production to accumulate towards nothing.

Marko Lindqvist wrote in #note-3:

I don't think the codebase is ready for convert genus building that's not actually producing anything. It's the targets "Gold" (and with this patch "Infra") that eat up the production so it does not accumulate towards a building, not the Convert genus. I don't know what would happen if you would let production to accumulate towards nothing.

It does look like the current code resets the shield stock purely based on whether it's Convert; but it's a fair point, we might want to hold off until we've properly formalized stuff around it.